ginkgo-project / ginkgo

Numerical linear algebra software package
https://ginkgo-project.github.io/
BSD 3-Clause "New" or "Revised" License
384 stars 86 forks source link

Add Batch jacobi device kernels #1600

Closed pratikvn closed 1 month ago

pratikvn commented 2 months ago

This PR adds the device kernels for batch Jacobi preconditioner.

pratikvn commented 1 month ago

Will merge this only once #1396 has been merged.

tcojean commented 1 month ago

@pratikvn I will check if I can find the issue with the SYCL backend. If I'm not successful, we can just not merge that.

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 84.90566% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 89.28%. Comparing base (1fc3d7d) to head (d7bc39e). Report is 13 commits behind head on develop.

:exclamation: Current head d7bc39e differs from pull request most recent head 691a479

Please upload reports for the commit 691a479 to get more accurate results.

Files Patch % Lines
reference/preconditioner/batch_scalar_jacobi.hpp 40.00% 6 Missing :warning:
reference/preconditioner/batch_block_jacobi.hpp 66.66% 1 Missing :warning:
test/preconditioner/batch_jacobi_kernels.cpp 97.22% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #1600 +/- ## =========================================== - Coverage 89.97% 89.28% -0.70% =========================================== Files 752 752 Lines 60445 60467 +22 =========================================== - Hits 54387 53985 -402 - Misses 6058 6482 +424 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

sonarcloud[bot] commented 1 month ago

Quality Gate Passed Quality Gate passed

Issues
7 New issues
0 Accepted issues

Measures
0 Security Hotspots
75.9% Coverage on New Code
9.6% Duplication on New Code

See analysis details on SonarCloud