ginkgo-project / ginkgo

Numerical linear algebra software package
https://ginkgo-project.github.io/
BSD 3-Clause "New" or "Revised" License
384 stars 86 forks source link

Fix the msvc failure on json config #1610

Closed yhmtsai closed 1 month ago

yhmtsai commented 1 month ago

Sorry for another pr on this. I thought the failure from msvc cuda, which is now always failed. To avoid setting the lib path in msvc, gko makes all test works in the library path (dll location). I changed the working directory to access testing file in #1607 However, it can not find the dll path now. follow the matrices/config.hpp.in to pass the file path

yhmtsai commented 1 month ago

I thought the same thing, too. but I also think we can use the filesystem to replace the path when we move to c++17.

upsj commented 1 month ago

@yhmtsai std::filesystem is still a bit annoying to use on some slightly older compilers, see https://en.cppreference.com/w/cpp/filesystem

Notes

Using this library may require additional compiler/linker options. GNU implementation prior to 9.1 requires linking with -lstdc++fs and LLVM implementation prior to LLVM 9.0 requires linking with -lc++fs

so I think we better avoid it.

ginkgo-bot commented 1 month ago

Error: PR already merged!

sonarcloud[bot] commented 1 month ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud