Fixes and updates, bump third party libraries

ginkgo-project / ginkgo

Numerical linear algebra software package

https://ginkgo-project.github.io/

BSD 3-Clause "New" or "Revised" License

384 stars 86 forks source link

Fixes and updates, bump third party libraries #1619

Closed tcojean closed 3 weeks ago

tcojean commented 1 month ago

This PR fixes some build and CI issues, also addresses some problems reported by users, and other release preparation aspects.

bump third party libraries
osx: try to also install (and run with) open-mpi in CI (disabled later, but works)
osx: try to help cmake find libomp (currently not found in MacOS CI!)
fix tests' gtest helpers: Pass OpenMP when required
Fix: Cast according to Issue #1562
benchmark: clarify manual vs helper script
build[msvc]: change the library structure to workaround the symbol limit
ci[msvc,cuda]: use windows 2019, which somehow works (windows-latest doesn't)
ci: workaround sonarqube issues on horeka

In some cases, the commit message has more details.

Closes issues #1481 #1482 #1141 #1562

tcojean commented 1 month ago

Small note that MPI seems to work with these MacOS runners with small changes, see: https://github.com/ginkgo-project/ginkgo/actions/runs/9290681420/job/25567479064?pr=1619 (only the benchmark tests fail because of a write issue which changes stdout/stderr).

I will disable MPI nonetheless because some test take a long time on these VM, and there is a risk of reaching the timeout.
I will keep the fixed OpenMP MacOS CI, as that was previously not tested.

codecov[bot] commented 3 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 90.03%. Comparing base (d7bc39e) to head (06868cb). Report is 45 commits behind head on develop.

:exclamation: Current head 06868cb differs from pull request most recent head 43189ba

Please upload reports for the commit 43189ba to get more accurate results.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## develop #1619 +/- ## =========================================== + Coverage 89.28% 90.03% +0.75% =========================================== Files 752 758 +6 Lines 60467 61154 +687 =========================================== + Hits 53985 55058 +1073 + Misses 6482 6096 -386 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

tcojean commented 3 weeks ago

Note that there is still a failure with the warnings job which is annoying: https://gitlab.com/ginkgo-project/ginkgo-public-ci/-/jobs/7016226162

A workaround for the issue is to add the C language to CMake, which allows CMake to properly find pthread. I believe more recent versions of CMake reviewed the FindThreads module which should also fix the issue.

My intuition is there is something wrong with the docker container, as I cannot seem to reproduce this easily. If anyone has an idea, I would be happy to test it.

MarcelKoch commented 3 weeks ago

Regarding the warnings CI fail, I would prefer if we don't enable the C language. I would be fine with this job failing for a while until we have a proper fix.

tcojean commented 3 weeks ago

Any other comments? Otherwise I'll merge this soon.

sonarcloud[bot] commented 3 weeks ago

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud