Release/1.8.0 - Githubissues

ginkgo-project / ginkgo

Numerical linear algebra software package

https://ginkgo-project.github.io/

BSD 3-Clause "New" or "Revised" License

415 stars 90 forks source link

Closed tcojean closed 5 months ago

tcojean commented 5 months ago

Release 1.8.0 to develop

tcojean commented 5 months ago

Please also check the last generated documentation for any mistake, typo, missing info, bug, ... https://ginkgo-project.github.io/ginkgo-generated-documentation/doc/develop/

tcojean commented 5 months ago

I don't think we need a separate PR to bump the version in develop, if people think it really is needed, then I can split this PR in two.

tcojean commented 5 months ago

There's also a bug with the mirroring as the branch name detection currently breaks on /. Using the improved github.ref_name variable should fix the issue, see: https://docs.github.com/en/actions/learn-github-actions/contexts#github-context

tcojean commented 5 months ago

I've looked at the documentation and didn't find something obviously bad myself. The main annoying point (but it's not critical) is that batch types somehow have two collaboration graphs inserted by doxygen: https://ginkgo-project.github.io/ginkgo-generated-documentation/doc/develop/classgko_1_1batch_1_1matrix_1_1Ell.html

It's the same for batched jacobi, etc.

tcojean commented 5 months ago

Yes, of course for master the PR will not use the commit that bumps to 1.9.0, you'll see it if I fail to remove it anyway.

ginkgo-bot commented 5 months ago

Error: PR already merged!

sonarcloud[bot] commented 5 months ago

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication