search

ginkgo-project / ginkgo

Numerical linear algebra software package
https://ginkgo-project.github.io/
BSD 3-Clause "New" or "Revised" License
409 stars 88 forks source link

Fix: transposed triangular solver uses the same algorithm as the original one #1641

Closed yhmtsai closed 4 months ago

yhmtsai commented 4 months ago

This PR changes the algorithm from transposed triangular solver from the default option to the source. first commit adds the test which shows failure and then second commit changes the algorithm.

sonarcloud[bot] commented 4 months ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

codecov[bot] commented 4 months ago

Codecov Report

Attention: Patch coverage is 95.83333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 91.60%. Comparing base (6c0da56) to head (b9a8c6a). Report is 31 commits behind head on develop.

Files Patch % Lines
reference/test/solver/lower_trs_kernels.cpp 95.45% 1 Missing :warning:
reference/test/solver/upper_trs_kernels.cpp 95.45% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #1641 +/- ## =========================================== + Coverage 90.01% 91.60% +1.58% =========================================== Files 759 761 +2 Lines 61173 61181 +8 =========================================== + Hits 55067 56045 +978 + Misses 6106 5136 -970 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.