Closed yhmtsai closed 4 months ago
@yhmtsai the second commit seems to be missing
@upsj Yes and sorry. I would like to wait for that some jobs of the first commit fail first
Issues
1 New issue
0 Accepted issues
Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 91.60%. Comparing base (
b9a8c6a
) to head (7cf1b31
). Report is 1 commits behind head on develop.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
We have the workaround for zero diagonal value in scalar Jacobi, but reference uses 1 but the others uses zero. I currently make it be 1. Note. it is not the proper inverse Jacobi matrix.
first commit adds the test and the second one fixes the issue.