search

ginkgo-project / ginkgo

Numerical linear algebra software package
https://ginkgo-project.github.io/
BSD 3-Clause "New" or "Revised" License
401 stars 88 forks source link

Add rocthrust through cmake #1668

Closed MarcelKoch closed 1 month ago

MarcelKoch commented 1 month ago

This PR uses CMake to find and add rocthrust. This fixes the spack issue reported in https://github.com/spack/spack/pull/44923.

MarcelKoch commented 1 month ago

I will wait merging this until https://github.com/spack/spack/pull/45791 is resolved. Maybe there is still something missing.

yhmtsai commented 1 month ago

question: do you create a patch in spack package? or should we release 1.8.1

MarcelKoch commented 1 month ago

There is a patch for the spack package. I think there is no need for an 1.8.1 otherwise.

MarcelKoch commented 1 month ago

The spack CI passed, so I consider this PR to be complete.