Unify and simplify batch functionality: solvers

ginkgo-project / ginkgo

Numerical linear algebra software package

https://ginkgo-project.github.io/

BSD 3-Clause "New" or "Revised" License

409 stars 88 forks source link

Unify and simplify batch functionality: solvers #1671

Closed pratikvn closed 2 months ago

pratikvn commented 2 months ago

This PR unifies and simplifies batched solvers and preconditioners. There were also ODR violations that I missed previously, which are now fixed.

TODO

[x] Simplify batched preconditioners

upsj commented 2 months ago

I was wondering: The previous PRs were even or a net reduction in the number of lines, this PR adds ~500 lines, where are they coming from?

pratikvn commented 2 months ago

The unnecessary headers should be removed now. I think I missed adding a few #ifdefs in the previous PRs, which I needed to add here, and hence the increased line count, but it should be less now with the removed superfluous headers.