search

ginkgo-project / ginkgo

Numerical linear algebra software package
https://ginkgo-project.github.io/
BSD 3-Clause "New" or "Revised" License
414 stars 88 forks source link

Fix parameter ordering/naming for reference (omp) batch CG #1701

Closed MarcelKoch closed 1 month ago

MarcelKoch commented 1 month ago

This PR fixes the parameter ordering of the initialize function for the reference+omp implementation of the batch CG. Additionally, a parameter name in update_x_and_r is changed to better reflect the actually used variable.

pratikvn commented 1 month ago

I think we re-arranged it so that the convergence check is first. But I dont see a particular reason for that. I will maybe compare the performance for both and maybe unify the device side to the reference one as well.

sonarcloud[bot] commented 1 month ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 92.05%. Comparing base (9e7bfa7) to head (30c2d86). Report is 2 commits behind head on develop.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #1701 +/- ## =========================================== + Coverage 90.24% 92.05% +1.81% =========================================== Files 764 764 Lines 62927 62678 -249 =========================================== + Hits 56787 57701 +914 + Misses 6140 4977 -1163 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.