Policy settings not respected, fields marked as FILL are updated when they shouldn't

ginkgostreet / com.ginkgostreet.geofill

When CiviCRM geocodes an address, the geocoding service generally returns much more information than CiviCRM uses. This extension allows site administrators to set a policy for what to do with that information on a field-by-field basis: discard it, fill in missing data, or overwrite existing data.

Other

4 stars 2 forks source link

Policy settings not respected, fields marked as FILL are updated when they shouldn't #4

Open ghost opened 7 years ago

ghost commented 7 years ago

The issue is with the way that getWritableAddressComponents evaluates the fields to update.

It compares "ID" fields against "non-ID" fields, which causes it to think that the value is empty and needs to be updated, when in fact it is not empty.

I created PR #3 with a simple fix, not sure if it's the best way to resolve the issue.

twomice commented 7 years ago

Hi @BhaktaB I'm not the maintainer but am just reviewing this extension. I'm not able to see the behavior you describe, at least as I understand it. Could I ask you please to a) list the exact steps to reproduce the problem, b) describe specifically where to observe the problem behavior? Thanks!