search

ginqi7 / leetcode-emacs

an emacs plugin to write leetcode programs
41 stars 7 forks source link

List names as a dependency #2

Closed anmoljagetia closed 5 years ago

anmoljagetia commented 5 years ago

While creating my package, I ran across this issue. I think you're using names to manage namespaces but it's not listed as a dependency. Will send a PR to add it to the README.

ginqi7 commented 5 years ago

Yes, it relies on package ctable to list all the leetcode question, and I will add that description to the README. Thanks for your suggestion.

anmoljagetia commented 5 years ago

Aren't you also using the names package for namespaces? I had to manually add that to the spacemacs layer.

ginqi7 commented 5 years ago

Yes, I use the names package. I forgot It.

ginqi7 commented 5 years ago

I fix this, add a require for names. 287ce40c4b10b39b593c83dbe00f588eb89de17a

anmoljagetia commented 5 years ago

Thanks. shouldn't we also add it to the README?

ginqi7 commented 5 years ago

Yes, I had added it. 8624496af9e105c3e07d88844b37ede87540d604

anmoljagetia commented 5 years ago

Perfect! Thank you once again for creating this wonderful tool and fixing all the bugs at your earliest!

anmoljagetia commented 5 years ago

I created a spacemacs layer for your package and it's available here.

Would be cool if you could send some of the spacemacs users that way (through README or something).

ginqi7 commented 5 years ago

I am very happy that this tool can help you and thank you for your spread.