search

ginsm / forgotten-graves

Minecraft (Fabric) mod that stores items and XP in a decaying grave upon death
https://modrinth.com/mod/forgotten-graves
MIT License
7 stars 4 forks source link

[BUG] Crashing on Death #37

Closed QzFulcrumX closed 2 years ago

QzFulcrumX commented 2 years ago

Describe the bug Crashing on death

Forgotten Graves Version forgottengraves-mc1.18.2-v2.5.0

To Reproduce A list of steps to reproduce your issue, i.e.:

  1. Spawned in a world (tried new and existing worlds, survival/creative)
  2. Die using any method (falling, fire, /kill command)
  3. See the Respawn/Title Screen buttons for a split second before crashing.
  4. After relogging, all items and XP are lost.

Expected behavior A grave will spawn on death location with items and XP inside.

Additional context Crash Report: https://pastebin.com/4SCsYjFx Debug Log: https://pastebin.com/SyaMAhgi Modlist(w/o forgottengraves): https://pastebin.com/AvVYQKQ8

Downloaded the mod and its dependencies, did not tweak any setting and started a world in single player. Without the mod, dying is no issue and back to vanilla behavior (dropped items, max 7 levels, etc.)

ginsm commented 2 years ago

Hey, thanks for creating the issue. Are you using CurseForge? If so, could you export the profile that's having issues and send the .zip here?

I'd like to test with your current mods to see what's going on and that'd save me a lot of time, thanks!

QzFulcrumX commented 2 years ago

I am unfortunately not, but I have edited in the mods I used as of this day, all of these are also downloaded today so it all will be their latest versions, except for inmis, which is from a comment chain from a guy who retextured the backpacks. retextured link dropbox

ginsm commented 2 years ago

Hmm, so I downloaded the mods and tested it but I couldn't replicate it:

https://user-images.githubusercontent.com/52685959/156571276-0389695c-d330-4ccd-bc16-e0fb9852ef12.mp4

I tried /kill, falling, burning myself in lava, burning myself with a flint and steel, shooting myself with a bow, etc.. it all worked properly.

I went ahead and changed the implementation of the line of code your game is having issues with though. Can you try this jar instead and see if it resolves your issue?

If it does, please let me know so I can use that implementation moving forward! :)

QzFulcrumX commented 2 years ago

It is now working and I found the culprit. image

I was using a shady cracked minecraft launcher that my friend recommended since only a few of us had a legit copy, after I reinstalled everything using curseforge and downloaded all mods again, it is now working flawlessly, somehow I knew this was caused by user error.

I think it would be wise to put a disclaimer on your page that your mod may or may not work on pirated copies, so you wouldn't get flooded by false bug reports.

ginsm commented 2 years ago

Gotcha haha, well glad you managed to get it working in the end. I'll look into adding a disclaimer along those lines, thanks.

Gonna close the issue now, enjoy! :)