gintau / bracket-match-highlighter

An extension of Adobe Brackets.
10 stars 9 forks source link

Change the color #1

Open thany opened 10 years ago

thany commented 10 years ago

In my setup, the color that this extension uses for highlights makes them unreadable, not to mention intrusive. It should be subtle.

Suggestion: when the background is dark, the the highlight color to rgba(255,255,255,.2) or something like that. When the background is light, set highlight color to something like rgba(0,0,0,.2).

gintau commented 10 years ago

I'd suggest to adjust default.css for the background. The color of background is decided by themes, it's impossible to simply classify whether the background is light or dark, for this extension to decide its highlighting color. Also, custom themes may override

.CodeMirror span.cm-matchhighlight 
for their own colors. My idea is the color should be considered as a part of theme, so I append my default class at the beginning to make custom theme overwrite it.

About the intrusiveness of color. My typical use is to find the usage of certain variables, in this case I'd like to make it obvious enough to easily locate the variables. If this is an issue when editing, I'll try to find a better color for other scenarios under default theme.

thany commented 10 years ago

I can imagine theme plugins not taking into account 3rd (4th?) party plugins. There are so many of them, and many add some visual element that might be styled... Anyway opened a ticket ;)

juanbodenser commented 8 years ago

I used dark theme of brackets, and when highlighting is white as the letters... So I can't read it.. how to solve this?

juanbodenser commented 8 years ago

ok I already changed the background color