Upgrade JavaParser dependency

matozoid commented 5 years ago

It's rather behind, and much has been improved.

justynapt commented 3 years ago

Test failures when trying to upgrade beyond 3.65 due to updated behaviour for Node.getData, throwing an IllegalStateException rather than null: https://java.libhunt.com/javaparser-changelog/3.6.26. Compiles fine with 3.12 if the following changes are made: Module{Opens/Uses/Provides/Requires/Exports/}Stmt -> Module{Opens/Uses/Provides/Requires/Exports/}Directive ForeachStmt -> ForEachStmt SwitchEntryStmt -> SwitchEntry for BreakStmt: removeLabel -> removeValue in any case test failures need to be resolved first

sandybrownlee commented 3 years ago

Now updated to JavaParser 3.22.1. Required further changes:

modifiers like "public" are now added to the node list in SourceFileStatement. This means that there are some extra node IDs (which are also statement IDs) - so the tests that fail are those expecting to see particular node IDs for the example source files. It might break things if anyone runs something that expects to see a particular node ID for a target source file (e.g., trying to run PatchAnalyser on patches generated by an old version of Gin on the updated one). Random number generator will also produce a different stream of patches as the total number of statements to choose from is different. Amended README to reflect this and updated unit tests to reflect new expected IDs.
"insert" edits needed some tweaking because of changed treatment of break/continue statements (which was then reverted in a still later version of JP)
extra node types added to CloneVisitorCopyIDs
changed name of some JavaParser classes

sandybrownlee commented 2 years ago

4122ea4 now updated to 3.24.0. Closing.

gintool / gin

Upgrade JavaParser dependency #32