search

gintool / gin

GI in No Time - a Simple Microframework for Genetic Improvement
MIT License
43 stars 21 forks source link

Edit fromString methods assume no spaces in filenames #34

Closed sandybrownlee closed 3 years ago

sandybrownlee commented 5 years ago

These methods typically use spaces to split into tokens for parsing. This split will include any spaces in the source file name.

sandybrownlee commented 4 years ago

Might be fixable with lookaheads in the call to split(). Needs investigation. Worst-case, needs a change to the toString() methods.

justynapt commented 4 years ago

The 'space' in the filename issue affects hprof in Profiler. Needs checking.

sandybrownlee commented 3 years ago

Fixed. Added quotes to filenames in all Edit.toString() methods, and necessary handling code to all fromString() methods. This should be backwards compatible; if no quotes present fromString should still work. Have tried adding spaces to paths in hprof tests for simple-gradle and it seemed to work okay still - possibly not a problem there. Closing until we can replicate any further issues with spaces.