Thanks!

[coderschoolreview]

Hello! Thank you for submitting the first homework for CoderSchool React Class 🎉! The main focus of this assignment was to introduce you to working with an API, rendering items in a collection, and dealing with state and props.

Great ✨

• Great work adapting the URL based on the width of the screen! Indeed for smaller screens you don't need to get the biggest images, that was very well played.
• Great work to keep the code clean and pretty. It is important to write code that easy to read and understand or other people, or even yourself.
• Good job fetching the data in App.js in componentDidMount. The official Facebook React Native example does this as well. (React and React Native have the same convention here.)
• Cool job using Bloomer library. It's nice to use a CSS Framework because you can build off base styles easily and quickly.

Not so great yet 🚩

• The I'm loading was never shown because the content variable was overriden. In the correction branch I showed a possible fix
• Function names should be camelCase, so ShowHide_Overview was not a good name. showHideOverview is better, or toggleOverview like I suggest in the correction.
• You should have renamed the path_2() function to path() and removed the first one as it was not used. It confused me at first.
• The MovieCard component takes a movies property whereas there is only 1 movie. It if confusing and it should be named movie. Defining the propTypes of your component would have helped, I showed you how to do that in the correction!
• The ShowHide_Overview.bind(this) should be done in the constructor() and not inside the onClick event. That is because .bind(this) creates a new function, which is a costly operation you only want to do once in the constructor, not everytime the users clicks.

[Tketa]

@gioan85 Note: I was not able to create a branch correction so I forked your repository and opened a pull-request there :) Can see it here: https://github.com/gioan85/homework/pulls

[gioan85]

tks for ur comment, it so helpful