issue: Splitting on CREDENTIALS_SEPARATOR can Break Authentication

[aglensmith]

Describe the issue

Its possible for password or username to contain CREDENTIALS_SEPARATOR. When this happens, authentication breaks.

To Reproduce Steps to reproduce the behavior:

1. During configuration, enter password or username that contains CREDENTIALS_SEPARATOR.
2. place breakpoint here
3. Run
4. username or password missing characters

Recommendation

• Base64 encode credentials before storage, or
• Add setting for custom separator, or
• Add functionality to pull credentials from environment variable, or
• Add functionality for entering base64 encoded credentials

[gioboa]

Hi, nice catch. :+1: If you want you can create a PR or if you prefer I will solve the issue. Thanks. :+1:

[gioboa]

I solved the issue. The plugin stored credentials in JSON format. If JSON.parse fail I assume the credentials were store by a previous version.

[gioboa]

@aglensmith
I solved the issue by my own, but if you want to contribute in something, you are welcome. 😄 👍