gioboa / jira-plugin

Jira plugin for VsCode
https://marketplace.visualstudio.com/items?itemName=gioboa.jira-plugin
MIT License
266 stars 41 forks source link

Unable to Use favourite Filters #47

Closed keithturley closed 5 years ago

keithturley commented 5 years ago

Using the favourites filter no results are returned despite me having 2 "Starred" filters in JIRA setup (Ive also tried to make the starred filters public and still no luck). Running on Jira Cloud and VS Code Version 1.30.1 (1.30.1)

If it wasnt for this one very significant issue then this would be the number 1 jira extension in VS Code for me. e.g. we have lots and lots of statuses amongst lots an lots of different jira projects, I work across projects and dont want to have to remember all the statuses and filter them etc... because I cant change your standard filters this presents me with an issue - ahha use the favourites filter selection - perfect, full control.... sadly no, its broke :-(

gioboa commented 5 years ago

Hi @keithturley so your first issue it's with favourite filters? Please can you explain better the second problem? Sorry but I didn't understand.

keithturley commented 5 years ago

I only have 1 issue and thatโ€™s the favourites

gioboa commented 5 years ago

The plugin exclude favourites filters with different project(from selected one) key/name inside jql. If you favorite filter have 2 project name inside jql the plugin remove it. It's consistency constraint.

UPDATE @keithturley If you open this url in your browser https://<your_jira_baseurl>/rest/api/2/filter/favourite you can retrive all the favourite filters in json format. (you must be logged in in the web application) Now if you copy and paste the json here -> https://jsoneditoronline.org/ you can see the data in readable way. Did you see any filters? If yes, can you have a look at this constraints? The plugin exclude favorites filters with different project(from selected one) key/name inside jql. If you favorite filter have 2 project name inside jql the plugin remove it. It's consistency constraint. Thanks ๐Ÿ‘

keithturley commented 5 years ago

Still not working.

[cid:image001.png@01D49911.5CDC9240]

Filter from JIRA:

[cid:image002.png@01D49911.5CDC9240]

gioboa commented 5 years ago

Sorry, I can't see any image.

keithturley commented 5 years ago

I called the API and got this back (only 1 project):

"jql": "project = TROP AND resolution = Unresolved AND assignee in (currentUser()) ORDER BY created DESC, updated DESC",

gioboa commented 5 years ago

ok perfect, did you select TROP in the working project in the status bar?

keithturley commented 5 years ago

Yes I did

keithturley commented 5 years ago

Select utilities is falling into this as I can see the prompt in the select dialog placeHolder: Select favourite filter, matchOnDescription: true so we know its finding some, itโ€™s just not displaying the pick list

gioboa commented 5 years ago

Do you have any errors in the output log?

keithturley commented 5 years ago

No nothing

I have forked the repo, is there anyway that I can install my local copy of the extension and then debug it with my credentials?

Im new to ts and vscode so would need a little help getting the debug up and running

gioboa commented 5 years ago

Yes, you can follow CONTRIBUTING file. If you find the problem you can create also a PR. ๐Ÿ‘ If you press F5 From VsCode (first instance), another instance of VsCode will be launched.(second instance). You can debug the second instance by the first one, breakpoint are available. Thanks.

keithturley commented 5 years ago

Ok, just opened up a dev copy, will see if I can fix it and then send you a PR

keithturley commented 5 years ago

I found the problem. I will work on a fix

gioboa commented 5 years ago

Thanks :+1:

gioboa commented 5 years ago

Fixed ๐Ÿ‘ Available in v 0.12.0