search

gioboa / jira-plugin

Jira plugin for VsCode
https://marketplace.visualstudio.com/items?itemName=gioboa.jira-plugin
MIT License
265 stars 41 forks source link

fix: Fixing issue with link provider by using proper configuration method #50

Closed knicefire closed 5 years ago

knicefire commented 5 years ago

I've noticed that after installing the plugin all negative numbers got highlighted. I've figured that this is an issue in link provider. There is the fix. Thanks a lot for the good work. I hope I'll be able to contribute more.

gioboa commented 5 years ago

Thanks @knicefire, so every negative number it's highlight? It's a really strange behavior. :confused:

knicefire commented 5 years ago

It happened because project always defaulted to an empty string.

I've changed that so now it highlights only if project is defined.

I'm thinking about being able to support highlighting of a ticket from any of available project. But I'll create a separate ticket for that :)

gioboa commented 5 years ago

@knicefire thanks for your help. :+1: :smile: If you want improve more the code you are welcome. :tada:

gioboa commented 5 years ago

@knicefire I released v 1.11.2 Now the plugin highlight correctly all words that are matching projects names. 👍

knicefire commented 5 years ago

Thanks. I'm very glad to help.

I've been wanting for such a a plugin for a long time and just haven't had enough courage to write it myself ))