gioboa / qwik-dream-demo

https://qwik-dream-demo.pages.dev/
28 stars 11 forks source link

Fix init dev #22

Closed dario-piotrowicz closed 1 year ago

dario-piotrowicz commented 1 year ago

While trying to installing and running the project locally I've found some issues so I'm opening this PR to amend them, I hope this can be helpful šŸ™‚


Regarding the @tailwindcss/forms dependency, this is what I was getting after a fresh npm install: Screenshot 2022-11-28 at 15 34 18 I can see the dependency in the app's local package.json but I think it would need to be at the root of the workspace, let me know if this is not correct šŸ™‚ (it did fix the issue for me)


After fixing the tailwind css forms dependency now don't get any errors in the terminal but I get this in my browser: Screenshot 2022-11-28 at 15 41 38

I'm going to look if I can fix this one as well (and update this PR) šŸ™‚

:point_up: I still haven't figured out how to correctly run the app locally, for the host instead of npm run preview I've tried npm run build.server + npm run serve which run the wrangler pages for the host (I assume that that is needed so that the pages functions can run?)

Anyways that sill doesn't seem to be doing the trick as then I do get the app running but it's unresponsive and all routes except the root one seem to be 404s: Screenshot at 2022-11-28 20-30-51

@gioboa do you have any suggestion on how to start the app locally? :slightly_smiling_face:

gioboa commented 1 year ago

Hi @dario-piotrowicz if you run all the apps with preview is it working? if not, which error do you have?

- cd apps/cart && npm run preview
- cd apps/hero && npm run preview
- cd apps/host && npm run preview
- cd apps/menu && npm run preview
- cd apps/product && npm run preview
- cd apps/reviews && npm run preview
dario-piotrowicz commented 1 year ago

Hi @gioboa I just did a fresh restart with everything and all seems ok (I'm generally using node 16 on my system and needed to switch to 18 for the dream-demo app, probably I started some process with the wrong node version when I was having issues... sorry about that šŸ™‚)

Anyways only the home page seems to show something for all the other routes I get 404 pages, is that correct?

gioboa commented 1 year ago

No, is not correct. The other apps are inside a specific folder e.g. http://localhost:5004/product/ you can see the right path in the terminal

dario-piotrowicz commented 1 year ago

@gioboa no sorry that's not what I meant, I can see all the apps/fragments in the home page (+ the cart): Screenshot 2022-11-30 at 22 03 03

What I was saying is just that the other pages all seem to give 404s, for example if I click on furniture: Screenshot 2022-11-30 at 22 03 14 I get this: Screenshot 2022-11-30 at 22 03 23 I actually haven't checked that part of the code but I assume that you've simply not yet implemented those pages?

gioboa commented 1 year ago

Yep, there is only the homepage with all the mircofrontend in it

gioboa commented 1 year ago

I think we can close it. What do you say?

dario-piotrowicz commented 1 year ago

Hi @gioboa sorry for the late reply, thanks for confirming, so I do get the app correctly running locally :slightly_smiling_face::+1:


Regarding the PR please have a look at the two changes I made as they are unrelated to the last issue I was asking you about and I think those still apply, if you disagree fill free to close the PR :slightly_smiling_face:

gioboa commented 1 year ago

I tried to remove @tailwindcss/forms from the tailwind configuration in the product app, but it's necessary because the