improve seams and labels

dario-piotrowicz commented 1 year ago

an attempt to improve the seams and labels :slightly_smiling_face:

before

before1

before2

after

after1

after2

Extra

I wanted to deploy the app so that I could provide a link here so that you could preview the changes, but I was afraid you wouldn't like me to deploy the app myself somewhere (let me know if that's not a problem so I can do that), so to check the changes you need to pull my branch down and run it
I am hiding the cart label and also the cart seams don't appear anywhere, I believe that there is a fundamental flaw with how the cart fragment is implemented, I'll explain it in the issue

gioboa commented 1 year ago

It looks nice 😉 I will try it in my environment and I will merge the PR. if you want you can deploy it in your cloudflare pages. You need a cloudflare account (free one is enough) and then with the CLI you can public all the apps. Btw I will add a npm script to automate this steps.

dario-piotrowicz commented 1 year ago

@gioboa cool, regarding the deployment, if you're going to try it locally anyways I can skip it for now and just do it next time for making PR review more convenient :slightly_smiling_face::+1:

gioboa commented 1 year ago

With this PR #28 I added npm scripts to deploy and preview

gioboa / qwik-dream-demo