giocomai / ganttrify

Create beautiful Gantt charts with ggplot2
https://ganttrify.europeandatajournalism.eu/
GNU General Public License v3.0
658 stars 62 forks source link

Ignoring linewidth #47

Closed Kath1240 closed 9 months ago

Kath1240 commented 9 months ago

Hi First, I love this tool, it makes such good charts. I have a little problem that when I run it says "Ignoring unknown parameters: linewidth" , I have 30 entries and think it could be because of this, I have tried altering size activity, but would appreciate any advice . Thanks in advance :)

giocomai commented 9 months ago

hi!

My guess is that this is related to the fact that you have an old version of ggplot2 installed on your system.

These days, I've been updating the package in preparation of a CRAN submission, and I have adapted the code in line with a new argument name convention introduced by ggplot2 with an update in November 2022.

In brief, an easy fix would be for you to update ggplot2 (just a basic: install.packages("ggplot2") and then restarting your R session should do), and all should work fine.

A second alternative would be installing an older version of ganttrify; like, anything older than a week should probably work.

Finally, I will try to figure out a way to let the code work for those who have an old version of ggplot, but still doesn't throw warnings for those who use a more recent version.

I'll leave this issue open until I find an adequate fix (note to self: probably described here)

Kath1240 commented 9 months ago

Thank you for your response.

giocomai commented 9 months ago

Alright, so I added a few lines that check which ggplot2 version you have installed, and deals with it internally.

If you just update ganttrify with remotes::install_github("giocomai/ganttrify"), and then restart R, things should work well on your side.

Please confirm if this is the case or if you still have this issue even after an update.

Kath1240 commented 9 months ago

Amazing, that works perfectly, thank you so much Have a lovely Friday :)

giocomai commented 9 months ago

cheers!