allPass currying fix - Githubissues

giogonzo / fp-ts-ramda

Ramda functions reimplemented in fp-ts

https://giogonzo.github.io/fp-ts-ramda/

MIT License

138 stars 9 forks source link

allPass currying fix #24

Closed kightlingerh closed 4 years ago

kightlingerh commented 4 years ago

I realized in my implementation that the currying would behave unexpectedly if a falsy value was supplied, so I made the condition in the ternary expression explicitly check for the argument to be undefined.

giogonzo commented 4 years ago

@kightlingerh good catch! Thanks for spotting this, I missed it in the review.

This PR though has a few issues, I've opened #25 instead

adding a type-level test is not really testing the execution of the function (only the type signature!). I added a test that actually fails on current master for 0
In general, I would say it is best to always call our FR.function implemented in fp-ts-ramda in the curried form in tests, in order to catch possible similar issues