search

giogonzo / fp-ts-ramda

Ramda functions reimplemented in fp-ts
https://giogonzo.github.io/fp-ts-ramda/
MIT License
138 stars 9 forks source link

add ifElse #33

Closed kutyel closed 2 years ago

kutyel commented 4 years ago

Fixes #32

I'm missing something obvious in the tests 🤔, but never used fast-check before 😆

kutyel commented 4 years ago

Hi @giogonzo, I applied some of your comments (the manual currying was a hell 😓 ). I still want to provide the second type signature you mentioned in https://github.com/giogonzo/fp-ts-ramda/issues/32#issuecomment-633199985, but I was not able to trick typescript (sorry not that familiar with it's type system yet 😅 ). Also, regarding the test I tried what you mention and I couldn't make it to compile, if you have a spare minute and can help get this merged I'll be glad 😉 (no hurry though!)