giometrix / Xtensible.TusDotNet.Azure

9 stars 5 forks source link

Allow Per Item Blob Path #3

Closed evancjohnson closed 9 months ago

evancjohnson commented 2 years ago

Hello @giometrix ,

I was wondering if you had considered allowing files to be added in a specific path? For example, with the user's id or a certain path in the given container.

I am more than happy to create a PR for this. You don't have any guidance for PRs or anything and if you aren't accepting any right now. Thank you for creating this library!

giometrix commented 2 years ago

PRs are happily accepted.

I will be on holiday til sept 5 so expect a short delay on feedback :)

giometrix commented 2 years ago

PRs are happily accepted.

I will be on holiday til sept 5 so expect a short delay on feedback :)

JohnCampionJr commented 9 months ago

I added this option on my fork. Let me know if interested in a PR. I also updated to .net6.0 and .net8.0 only and a few other tidying changes.

giometrix commented 9 months ago

@JohnCampionJr Very interested! Thank you

JohnCampionJr commented 9 months ago

@giometrix Will do. I made one other change I wanted to check. I removed the dependency on your mockable clock for an easy 3 line bit of code as seen here: https://ayende.com/blog/3408/dealing-with-time-in-tests

I'm not a fan of extra packages for minimal code, but I recognize its your code which is why I'm asking :)

OK if I include this in my PR or would you rather it be left alone?

giometrix commented 9 months ago

Go for it. That time package is also mine 🤓 but I'm not married to it.

Also seems redundant now (https://levelup.gitconnected.com/bending-datetime-in-net-8-to-test-your-code-better-52e5cd83be4c)

JohnCampionJr commented 9 months ago

That's what I meant; it's your time package. I saw the new official way too, but it feels like way too much extra code for this relatively simple, only-needed-one-place bit of code :).

PR coming....

giometrix commented 9 months ago

@JohnCampionJr thanks for the PR. nuget package incoming!