giordano / Cuba.jl

Library for multidimensional numerical integration with four independent algorithms: Vegas, Suave, Divonne, and Cuhre.

https://giordano.github.io/Cuba.jl/stable

MIT License

75 stars 9 forks source link

Fix depwarn and error in the test on 0.6 #5

Closed yuyichao closed 7 years ago

giordano commented 7 years ago

Thank you. SpecialFunctions should be added test/REQUIRE (or I should use integrals not involving special functions). I can do that, if you don't have the time.

yuyichao commented 7 years ago

......................... I did that in the local version but I think I did a git clean before running git add . ..........................

yuyichao commented 7 years ago

hmm. that's not what happened.. seems taht REQUIRE is ignored?...

yuyichao commented 7 years ago

I added test/REQUIRE, why is test/ ignored?

giordano commented 7 years ago

why is test/ ignored?

Good question, I probably ignored the whole directory when I should have ignored only the generated files. Thanks for spotting.

codecov-io commented 7 years ago

Codecov Report

Merging #5 into master will not change coverage. The diff coverage is n/a.

@@          Coverage Diff          @@
##           master     #5   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           1      1           
  Lines          37     37           
=====================================
  Hits           37     37

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 7dbe36c...9cdfa79. Read the comment docs.

giordano commented 7 years ago

I liked the idea of having exact results, but they're not really useful, as the integrals are computed with much lower precision. Constant literals avoids loading an external package just for the test (which makes the test annoyingly slow). Thanks again.

coveralls commented 7 years ago

Coverage remained the same at 100.0% when pulling 545589712101b44bf70df1a9967d0bc152147a68 on yuyichao:0.6 into 7dbe36c99a3f1770fdb993c0fb9344dbd6bf4493 on giordano:master.