search

giordano / PolynomialRoots.jl

Fast complex polynomial root finder, with support for arbitrary precision calculations
Other
53 stars 15 forks source link

fix type errors #20

Closed lkapelevich closed 4 years ago

lkapelevich commented 4 years ago 
Random.seed!(1)
p = rand(Float32, 4)
PolynomialRoots.roots(p)

was running into:

ERROR: MethodError: no method matching eval_poly_der2_ek(::Complex{Float64}, ::Array{Complex{Float32},1}, ::Int64, ::Complex{Float32})
Closest candidates are:
  eval_poly_der2_ek(::T, ::AbstractArray{T,1}, ::Any, ::Any) where T<:Complex at /home/hypatia/.julia/dev/PolynomialRoots/src/PolynomialRoots.jl:121
Stacktrace:
 [1] laguerre2newton(::Array{Complex{Float32},1}, ::Int64, ::Complex{Float32}, ::Int64, ::Float32) at /home/hypatia/.julia/dev/PolynomialRoots/src/PolynomialRoots.jl:349
 [2] roots!(::Array{Complex{Float32},1}, ::Array{Complex{Float32},1}, ::Float64, ::Int64, ::Bool) at /home/hypatia/.julia/dev/PolynomialRoots/src/PolynomialRoots.jl:588
 [3] roots(::Array{Float32,1}; epsilon::Float64, polish::Bool) at /home/hypatia/.julia/dev/PolynomialRoots/src/PolynomialRoots.jl:630
 [4] roots(::Array{Float32,1}) at /home/hypatia/.julia/dev/PolynomialRoots/src/PolynomialRoots.jl:623
 [5] top-level scope at REPL[46]:1
giordano commented 4 years ago

Awesome, thank you so much!

lkapelevich commented 4 years ago

@giordano would you mind tagging this?

giordano commented 4 years ago

This is already in v1.0.0 :slightly_smiling_face:

lkapelevich commented 4 years ago

oops I missed that. thanks!