search

giordano / PolynomialRoots.jl

Fast complex polynomial root finder, with support for arbitrary precision calculations
Other
54 stars 15 forks source link

Fix Julia 0.7 tests and deprecation warnings #6

Closed simonfxr closed 6 years ago

simonfxr commented 6 years ago

Tests for 5-th order polynomials failed, after some investigation it seems like the implementation of ::Complex ^ ::Float has changed since 0.6 and now has a bit less precision. Fixed by replacing the a ^ b operator with exp(log(a) * b) (this is basically how 0.6 implements exponentiation). I'm going to file a bug report against Julia when I get the time to do so.

I also fixed a deprecation warning regarding loop scope changes by introducing another auxiliary variable.

giordano commented 6 years ago

Great, thank you so much! LGTM overall, I've only a minor comment about the test file.