giorgi-o / CrossPlatformPlaying

BetterDiscord plugin that lets you see what your friends are playing even if they turned off game activity
59 stars 5 forks source link

Work with new discord version #9

Open giorgi-o opened 2 years ago

giorgi-o commented 2 years ago

This uses a custom preload script to inject into discord's main process and expose some custom functions for opening net/tls sockets, therefore working almost like before the update.

I say almost, because some extra setup is required to get it working:

Once you reopen Discord, you can install the beta version of the plugin as usual in the plugins folder.

The short term plan is to automate this process, so that it happens in one click when you first install the plugin.
The long term plan is to try and get the net/tls wrappers integrated into BetterDiscord itself, to not need to do this setup at all.

Let me know if anything doesn't work, either by opening a new issue or replying to this PR :)

ZeddPerm commented 2 years ago

Getting a TypeError: Cannot read property 'children' of undefined) image

image

giorgi-o commented 2 years ago

Yup, seems to happen when you open the settings panel. It's a bug with ZeresPluginLibrary, so we gotta wait for them to fix it.

In the meantime you can always edit CrossPlatformPlaying.config.json directly if you need to.

ZeddPerm commented 1 year ago

I'm getting a different error when trying to open the settings panel now. image

ZeddPerm commented 1 year ago

Yup, seems to happen when you open the settings panel. It's a bug with ZeresPluginLibrary, so we gotta wait for them to fix it.

In the meantime you can always edit CrossPlatformPlaying.config.json directly if you need to.

Could you elaborate on what the exact issue with ZeresPluginLibrary is? I would like to open an issue about it in their github repo. Or you can open the issue yourself.

JustinsKittens commented 1 year ago

Whenever I add the contents of add_this_to_index.js to index.js and Alt+F4 Discord, Discord doesn't re-open until I revert the changes to index.js

Please help!

Bamboozul commented 1 year ago

Instead of going to %localappdata%/Discord/App-1.0.XXXX/resources/app go to %localappdata%/Discord/App-1.0.XXXX/modules/discord_desktop_core-1/discord_desktop_core and then proceed with the rest of the steps.

Cloakster0 commented 1 year ago

Hi, is this plugin still being updated?

CHICKENMAN1128 commented 10 months ago

I do not see any file or anything named app under resources. Might just be on my side but would appreciate any help

KfkFod commented 5 months ago

i was gonna ask if the rich presence feature support is implemented, or will it be implemented later?