search

giorgi-o / SkinPeek

Awesome Valorant Discord bot to see your daily shop, night market, battlepass progression, and much more
GNU General Public License v3.0
210 stars 87 forks source link

See the shop of other users #31

Closed tim-it-ger closed 2 years ago

tim-it-ger commented 2 years ago

hello,

i added a optional function for: /shop

now you can show the shop from other users! :)

just use: /shop [user]

warriorzz commented 2 years ago

Furthermore, you should add the new translation to every language.json file, just use the English version (at least this was the last "policy" I've seen).

giorgi-o commented 2 years ago

Thanks for the PR! This is actually a really neat idea, although it does have a few asterisks.

My first concern is that it might be used to grab random people's Valorant in-game names, which not everyone might want anyone to be able to see on command. The solution to that would be to replace it with a discord mention, something like

Daily shop for @user (new shop in 10 hours)

This also has the good side effect of being visually clear when they are using /shop on themselves or on someone else at a glance.


The other trickier concern is that not everyone might want to make their shop visible to everyone. That being said, there isn't exactly anything personal about someone's daily shop rotation, and I can already think of a situation where someone is away on holiday or something, and their friends check their shop while they're away, and they find out that they missed out on the reaver vandal or something...

A solution to this as proposed by @warriorzz is to make it customizable, either through a /settings command (per guild or per user), or more ingeniously through a prompt or DM the first time they use /shop, with a message like

I've noticed you've used /shop for the first time! Would you like to allow other users to see your shop? (Yes/No)

Overall, this feature is a nice quality-of-life addition to the bot, and ideal for bots hosted by a small group of friends, but I'll have to think about it a bit more. Of course if anyone wants to chip in, please do!

warriorzz commented 2 years ago

Any updates on this? @tim-it-ger

giorgi-o commented 2 years ago

closed due to inactivity, and the code being incompatible with the upcoming #41.

giorgi-o commented 2 years ago

implemented in https://github.com/giorgi-o/SkinPeek/commit/edca6b0fbe37d64a74565e647316a50b1b22b947 👀