giorgiosironi / phpunit-selenium

Selenium RC integration for PHPUnit
http://www.phpunit.de/
Other
600 stars 271 forks source link

Transfer ownership (and decouple from PHPUnit) #321

Open sebastianbergmann opened 10 years ago

sebastianbergmann commented 10 years ago
GrahamCampbell commented 10 years ago

Is the packagist name remaining the same?

sebastianbergmann commented 10 years ago

That would be up to @giorgiosironi. But I guess it would remain the same.

GrahamCampbell commented 10 years ago

Sure, thanks. It would be break all existing code if the name was changed, that's why I asked.

giorgiosironi commented 10 years ago

I agree it should remain the same.

giorgiosironi commented 10 years ago

Now waiting for transfer of ownership. @GrahamCampbell the packagist name is phpunit/phpunit-selenium so it should not be affected, what else is needed to ensure a smooth transition?

giorgiosironi commented 10 years ago

I think the canonical source will have to be updated at: https://packagist.org/packages/phpunit/phpunit-selenium

michaelhodgins commented 10 years ago

I can't install the package with composer. I get this message when I try:

[Composer\Downloader\TransportException] The "https://api.github.com/repos/sebastianbergmann/phpunit-selenium/zipball/83a2b834c8395ad9510f7c8f4f46d498ce88565b" file could not be downloaded (HTTP/1.1 404 Not Found)

giorgiosironi commented 10 years ago

At https://packagist.org/packages/phpunit/phpunit-selenium I cannot find any option to change the Canonical url and put the new repository. @sebastianbergmann do you have such options with your login on Packagist?

sebastianbergmann commented 10 years ago

I changed the canonical URL days ago:

screenshot from 2014-08-21 07 05 35

jacques commented 10 years ago

Seeing:

$ composer update
Loading composer repositories with package information
Updating dependencies (including require-dev)
  - Removing phpunit/phpunit-selenium (1.3.3)
  - Installing phpunit/phpunit-selenium (1.4.1)
    Downloading: connection...
Could not fetch https://api.github.com/repos/sebastianbergmann/phpunit-selenium/zipball/83a2b834c8395ad9510f7c8f4f46d498ce88565b, enter your GitHub credentials to access private repos
The credentials will be swapped for an OAuth token stored in /Users/jacques/.composer/config.json, your password will not be stored
To revoke access to this token you can visit https://github.com/settings/applications
Username:

Is there anyway to get @GitHub to add a redirect for the zipballs?

hermo commented 10 years ago

All the release versions except dev-master seem to still be pointing at the old sebastianbergmann/* dist urls:

$ php composer phar show phpunit/phpunit-selenium 1.3.1

Results in:

name     : phpunit/phpunit-selenium
descrip. : Selenium Server integration for PHPUnit
keywords : testing, selenium, xunit
versions : 1.3.1
type     : library
license  : BSD-3-Clause
source   : [git] https://github.com/sebastianbergmann/phpunit-selenium.git b8c6494b977f79098e748343455f129af3fdb292
dist     : [zip] https://api.github.com/repos/sebastianbergmann/phpunit-selenium/zipball/b8c6494b977f79098e748343455f129af3fdb292 b8c6494b977f79098e748343455f129af3fdb292

Is there any way of fixing the dist urls?

jacques commented 10 years ago

@hermo I mailed the Packagist maintainers last week asking about the meta data issue. Hopefully they have a simple fix this.

GrahamCampbell commented 10 years ago

Does clearing the your composer cache not fix this?

michaelhodgins commented 10 years ago

I don't believe so. This was my first time using Composer, so I wouldn't have had a cache.

ctrlaltca commented 10 years ago

So, i recently updated selenium and incurred in the problem of the value() method being removed; i then saw phpunit-selenium added a workaround for the problem, so i tried updating it with composer and ended up with the problem described in this ticket. My workaround has been to run composer with the "--prefer-source" flag to download the package from git:

composer update --prefer-source phpunit/phpunit-selenium
michaelhodgins commented 10 years ago

Cool, thanks, ctrlaltca, that worked for me.

Spea commented 10 years ago

The meta information for 1.3.1 are now correct, but the ones for 1.4.1 are (still?) wrong

name     : phpunit/phpunit-selenium
descrip. : Selenium Server integration for PHPUnit
keywords : testing, selenium, xunit
versions : 1.4.1
type     : library
license  : BSD-3-Clause
source   : [git] https://github.com/sebastianbergmann/phpunit-selenium.git 83a2b834c8395ad9510f7c8f4f46d498ce88565b
dist     : [zip] https://api.github.com/repos/sebastianbergmann/phpunit-selenium/zipball/83a2b834c8395ad9510f7c8f4f46d498ce88565b 83a2b834c8395ad9510f7c8f4f46d498ce88565b
names    : phpunit/phpunit-selenium

Due to this I get the same error as already described here: https://github.com/giorgiosironi/phpunit-selenium/issues/321#issuecomment-53098272 Do you know how to fix this?

miogalang commented 10 years ago
- Installing phpunit/phpunit-selenium (1.4.1)
  Downloading: connection...

[Composer\Downloader\TransportException]
The "https://api.github.com/repos/sebastianbergmann/phpunit-  selenium/zipball/83a2b834c8395ad9510f7c8f4f46d498ce88565b" file could not be downloaded (HTTP/1.1 404 Not Found)

Still getting this on update

I think the meta data still has not been fixed. Is there any way to fix this?

$ composer show phpunit/phpunit-selenium 1.4.1
name     : phpunit/phpunit-selenium
descrip. : Selenium Server integration for PHPUnit
keywords : testing, selenium, xunit
versions : 1.4.1
type     : library
license  : BSD-3-Clause
source   : [git] https://github.com/sebastianbergmann/phpunit-selenium.git   83a2b834c8395ad9510f7c8f4f46d498ce88565b
dist     : [zip] https://api.github.com/repos/sebastianbergmann/phpunit-  selenium/zipball/83a2b834c8395ad9510f7c8f4f46d498ce88565b 83a2b834c8395ad9510f7c8f4f46d498ce88565b
names    : phpunit/phpunit-selenium

autoload
classmap
PHPUnit/
include-path

requires
php >=5.3.3
phpunit/phpunit >=3.7
sebastian/comparator ~1.0
ext-curl *
ext-dom *
giorgiosironi commented 10 years ago

I get this on a fresh installation:

[10:36:55][giorgio@Desmond:~/code/phpunit-selenium-test]$ composer.phar install
Loading composer repositories with package information
Installing dependencies (including require-dev) from lock file
  - Installing sebastian/version (1.0.3)
    Loading from cache

  - Installing sebastian/environment (1.1.0)
    Loading from cache

  - Installing phpunit/php-token-stream (1.3.0)
    Loading from cache

  - Installing phpunit/php-text-template (1.2.0)
    Loading from cache

  - Installing phpunit/php-file-iterator (1.3.4)
    Loading from cache

  - Installing phpunit/php-code-coverage (2.0.11)
    Loading from cache

  - Installing phpunit/php-timer (1.0.5)
    Loading from cache

  - Installing doctrine/instantiator (1.0.3)
    Loading from cache

  - Installing phpunit/phpunit-mock-objects (2.3.0)
    Loading from cache

  - Installing sebastian/exporter (1.0.2)
    Loading from cache

  - Installing sebastian/diff (1.2.0)
    Loading from cache

  - Installing sebastian/comparator (1.0.1)
    Loading from cache

  - Installing symfony/yaml (v2.5.5)
    Loading from cache

  - Installing phpunit/phpunit (4.3.1)
    Loading from cache

  - Installing phpunit/phpunit-selenium (1.4.1)
    Downloading: connection...Failed to download phpunit/phpunit-selenium from dist: The "https://api.github.com/repos/sebastianbergmann/phpunit-selenium/zipball/83a2b834c8395ad9510f7c8f4f46d498ce88565b" file could not be downloaded (HTTP/1.1 404 Not Found)
Now trying to download from source
  - Installing phpunit/phpunit-selenium (1.4.1)
    Cloning 83a2b834c8395ad9510f7c8f4f46d498ce88565b

phpunit/php-code-coverage suggests installing ext-xdebug (>=2.2.1)
phpunit/phpunit suggests installing phpunit/php-invoker (~1.1)
Generating autoload files

so at least it does not block installation as Composer retries downloading from the source repository. @miogalang does it block installation for you? I want to report exactly the problem to Packagist.

miogalang commented 10 years ago

I forgot what I did but I got the same thing and it eventually worked exactly like that. I think I cleared the cache of composer but i am not 100% sure what I did to make it work this way.

On Sat, Oct 11, 2014 at 4:39 PM, Giorgio Sironi notifications@github.com wrote:

I get this on a fresh installation:

[10:36:55][giorgio@Desmond:~/code/phpunit-selenium-test]$ composer.phar install Loading composer repositories with package information Installing dependencies (including require-dev) from lock file

  • Installing sebastian/version (1.0.3) Loading from cache
  • Installing sebastian/environment (1.1.0) Loading from cache
  • Installing phpunit/php-token-stream (1.3.0) Loading from cache
  • Installing phpunit/php-text-template (1.2.0) Loading from cache
  • Installing phpunit/php-file-iterator (1.3.4) Loading from cache
  • Installing phpunit/php-code-coverage (2.0.11) Loading from cache
  • Installing phpunit/php-timer (1.0.5) Loading from cache
  • Installing doctrine/instantiator (1.0.3) Loading from cache
  • Installing phpunit/phpunit-mock-objects (2.3.0) Loading from cache
  • Installing sebastian/exporter (1.0.2) Loading from cache
  • Installing sebastian/diff (1.2.0) Loading from cache
  • Installing sebastian/comparator (1.0.1) Loading from cache
  • Installing symfony/yaml (v2.5.5) Loading from cache
  • Installing phpunit/phpunit (4.3.1) Loading from cache
  • Installing phpunit/phpunit-selenium (1.4.1) Downloading: connection...Failed to download phpunit/phpunit-selenium from dist: The "https://api.github.com/repos/sebastianbergmann/phpunit-selenium/zipball/83a2b834c8395ad9510f7c8f4f46d498ce88565b" file could not be downloaded (HTTP/1.1 404 Not Found) Now trying to download from source
  • Installing phpunit/phpunit-selenium (1.4.1) Cloning 83a2b834c8395ad9510f7c8f4f46d498ce88565b

phpunit/php-code-coverage suggests installing ext-xdebug (>=2.2.1) phpunit/phpunit suggests installing phpunit/php-invoker (~1.1) Generating autoload files

so at least it does not block installation as Composer retries downloading from the source repository. @miogalang https://github.com/miogalang does it block installation for you? I want to report exactly the problem to Packagist.

— Reply to this email directly or view it on GitHub https://github.com/giorgiosironi/phpunit-selenium/issues/321#issuecomment-58742738 .

buskamuza commented 10 years ago

The problem with --prefer-source (or allow Composer to load from source) is that it doesn't allow Composer to cache the result, so it will download this package again and again. And it weights 47.1MB, as I understand. In my example, it's an issue because it slows down CI - we download same repository for every builds, while we want fully utilize Composer cache to make everything faster.

buskamuza commented 10 years ago

If for somebody else it's critical to download dist instead of source, here is my solution.

Updated. add this repository to the list of custom repositories as CVS. Turned out "package" type is a wrong solution, as it doesn't make Composer to read composer.json file.

{
    "repositories": [
        {
            "type": "vcs",
            "url": "https://github.com/giorgiosironi/phpunit-selenium.git"
        }
    ],
    "require": {
        "phpunit/phpunit-selenium": ">=1.2"
    }
}
djjohnjosephuk commented 10 years ago

EDIT - above post worked for me on an install after removing the lock file

buskamuza commented 10 years ago

@djjohnjosephuk , you can use composer update also - it makes Composer to re-read information from composer.json

giorgiosironi commented 10 years ago

A clean installation of 1.4.2 is working without errors:

{
    "name": "giorgio/code",
    "require": {
        "phpunit/phpunit-selenium": "@stable"
    }
}
[10:25:08][giorgio@Desmond:~/code/phpunit-selenium-test]$ composer.phar install
Loading composer repositories with package information
Installing dependencies (including require-dev)
  - Installing sebastian/exporter (1.0.2)
    Loading from cache

  - Installing sebastian/diff (1.2.0)
    Loading from cache

  - Installing sebastian/comparator (1.0.1)
    Loading from cache

  - Installing sebastian/version (1.0.3)
    Loading from cache

  - Installing sebastian/environment (1.2.0)
    Downloading: 100%         

  - Installing symfony/yaml (v2.5.6)
    Downloading: 100%         

  - Installing doctrine/instantiator (1.0.4)
    Downloading: 100%         

  - Installing phpunit/php-text-template (1.2.0)
    Loading from cache

  - Installing phpunit/phpunit-mock-objects (2.3.0)
    Loading from cache

  - Installing phpunit/php-timer (1.0.5)
    Loading from cache

  - Installing phpunit/php-file-iterator (1.3.4)
    Loading from cache

  - Installing phpunit/php-token-stream (1.3.0)
    Loading from cache

  - Installing phpunit/php-code-coverage (2.0.11)
    Loading from cache

  - Installing phpunit/phpunit (4.3.4)
    Downloading: 100%         

  - Installing phpunit/phpunit-selenium (1.4.2)
    Downloading: 100%         

phpunit/php-code-coverage suggests installing ext-xdebug (>=2.2.1)
phpunit/phpunit suggests installing phpunit/php-invoker (~1.1)
Writing lock file
Generating autoload files
giorgiosironi commented 10 years ago

@sebastianbergmann shall we remove you from the composer.json?

sebastianbergmann commented 10 years ago

Don't mind either way.