search

giorgiosironi / phpunit-selenium

Selenium RC integration for PHPUnit
http://www.phpunit.de/
Other
602 stars 271 forks source link

Fixes #354 waitUtil timeout and sleep interval more configurable #374

Closed gsouf closed 8 years ago

gsouf commented 8 years ago

Didn't run the test suit because I dont use vagrant, but travis is a good boy :-)

giorgiosironi commented 8 years ago

Some test related to waitUntil fail, maybe they need to be updated: https://travis-ci.org/giorgiosironi/phpunit-selenium/jobs/115337340

gsouf commented 8 years ago

All my bad, I introduced a typo in assertEquals Not glorious

giorgiosironi commented 8 years ago

Thank you for your contribution. I have added some comments about the style in order to make all APIs consistent with each other (once they are in master they are set in stone) and I will merge after those are dealt with.

gsouf commented 8 years ago

About coding standard, that would be a good idea to add a CONTIBUTING.md file, and also some phpcs xml file with the rules, then we can run phpcbf. By the way I will fix these very soon, thanks for the inputs

gsouf commented 8 years ago

Sorry for the delay, my contribution interval was not tuned correctly :D

giorgiosironi commented 8 years ago

Thanks!