Make compatible with phpunit 5.x

giorgiosironi / phpunit-selenium

Selenium RC integration for PHPUnit

http://www.phpunit.de/

Other

602 stars 271 forks source link

Make compatible with phpunit 5.x #381

Closed silasfn closed 7 years ago

silasfn commented 8 years ago

Changed PHPUnit_Framework_TestSuite::isPublicTestMethod to PHPUnit_Framework_TestSuite::isTestMethod (because former was removed in phpunit 4.0).

giorgiosironi commented 8 years ago

As you can see in the readme file: The old line 1.x is not maintained anymore, but will continue to be available for usage of SeleniumTestCase. For PHPUnit 5.x the correct version is 3.x, but it is without the old Selenium 1 support. The reason is there are many incompatible things inside that code (it's very old), not just this method.

PowerKiKi commented 7 years ago

I believe this should be closed

giorgiosironi commented 7 years ago

Correct, this has been solved through new major releases.