Closed paulbriton closed 7 years ago
It also fixes the travis build, my bad.. But changes would not be included in the PHPUnit 4.8 phar unless to build it manually.
Do you want me to port it to the master
?
master
is where 3.x
releases come from, not 1.x
ones. From that conversation I understand PHPUnit 4.8 is about to become unsupported, so I am afraid solutions targeting PHPUnit 4.8 are a quick fix but will raise the problem again very soon.
What is it in the build that makes it depend on 4.8? Eventually it will have to run for multiple and never PHP versions that are not supported by 4.8. What is it that makes your projects depend on 4.8 instead?
Yes I know about master
. I ask this in order to also fix the test suite for this line.
I don't think there is any explicit dependence on 4.8 on the build. As I told you, I would build my PHPUnit phar manually. So basically there is no longer an issue. I just thought that my changes needs to be present on the PHPUnit 4.8 phar.
Mostly ready for merge but I added a couple of questions on some tests that are now probably unstable.
Thank you for your work on the build. If you want to forward-port it to master
I'll be glad to merge it there and release both versions.
Here are the changes to repair vagrant build.
It should also repair the travis build but there are some complications:
~1.4
What do you suggest to include those changes in PHPUnit 4.8 ?