Only collect code coverage when a coverage url has been configured

giorgiosironi / phpunit-selenium

Selenium RC integration for PHPUnit

http://www.phpunit.de/

Other

602 stars 271 forks source link

Only collect code coverage when a coverage url has been configured #400

Closed egeloen closed 7 years ago

egeloen commented 7 years ago

Hey!

I'm facing #395 and this PR tries to fix this specific issue. Basically, this PR disables code coverage if the coverage url has not been configured (meaning the developer doesn't care about code coverage for its selenium test cases).

Using my fork on one of my projects allows me to pass from this build to this build :)

What do you think?

giorgiosironi commented 7 years ago

Make sense. Will merge after we have fixed the build in #399.

egeloen commented 7 years ago

@giorgiosironi PR rebased

egeloen commented 7 years ago

@giorgiosironi Is there anything missing for merging?

giorgiosironi commented 7 years ago

Thank you, didn't get the notification.

egeloen commented 7 years ago

No problem :) Thanks for merging :+1:

luckydonald commented 6 years ago

Is this available in ~3.0.3?