search

giorgiosironi / phpunit-selenium

Selenium RC integration for PHPUnit
http://www.phpunit.de/
Other
602 stars 271 forks source link

Adding keepSessionOnFailure function. #409

Closed raulgomezc closed 7 years ago

raulgomezc commented 7 years ago

So you can keep using the same browser session when an assert fails or there's an error.

giorgiosironi commented 7 years ago

This adds an argument to a constructor, but it seems there are some calls that are not passing it:

Warning: Missing argument 2 for PHPUnit_Extensions_Selenium2TestCase_SessionStrategy_Shared::__construct(), called in /home/travis/build/giorgiosironi/phpunit-selenium/PHPUnit/Extensions/Selenium2TestCase.php on line 290 and defined in /home/travis/build/giorgiosironi/phpunit-selenium/PHPUnit/Extensions/Selenium2TestCase/SessionStrategy/Shared.php on line 65

Could the argument be made optional? Could these calls be updated?

raulgomezc commented 7 years ago

Fixed the issue, what was causing it was that I didn't keep in mind the calls made by the browser's function. @giorgiosironi

giorgiosironi commented 7 years ago

After https://github.com/giorgiosironi/phpunit-selenium/pull/403 will be merged, this will go into 4.x versions, that only support PHPUnit 6. Is that appropriate for you or would you like to backport this to previous versions? (e.g. because you use a older PHPUnit)

raulgomezc commented 7 years ago

Good for me