search

giorgiosironi / phpunit-selenium

Selenium RC integration for PHPUnit
http://www.phpunit.de/
Other
601 stars 270 forks source link

Added secure server flag for https selenium servers #426

Closed pankaj-a closed 6 years ago

pankaj-a commented 6 years ago

The server url was resolved by concatenation in the fromHostAndPort method in URL.php. There was no way to create an https server url from host and port. Added a secure flag in the parameters which is passed to the method, and the URL is created accordingly.

giorgiosironi commented 6 years ago

Haven't seen this use case before, but it's valid. To minimize the surface of the API, I'd prefer for $host to accept values like https://... but then it wouldn't be called host anymore so that wouldn't be a good direction.

pankaj-a commented 6 years ago

@giorgiosironi to keep the changes to a minimum I opted to add a parameter, instead of changing the host variable to be the url. Fixed the code formatting error.

giorgiosironi commented 6 years ago

The test failure on coverage is not related so this can go in, sorry for the wait but I don't have much time to dedicate to this open source project.