Closed pankaj-a closed 6 years ago
Haven't seen this use case before, but it's valid. To minimize the surface of the API, I'd prefer for $host
to accept values like https://...
but then it wouldn't be called host
anymore so that wouldn't be a good direction.
@giorgiosironi to keep the changes to a minimum I opted to add a parameter, instead of changing the host
variable to be the url
.
Fixed the code formatting error.
The test failure on coverage is not related so this can go in, sorry for the wait but I don't have much time to dedicate to this open source project.
The server url was resolved by concatenation in the
fromHostAndPort
method in URL.php. There was no way to create an https server url from host and port. Added asecure
flag in theparameters
which is passed to the method, and the URL is created accordingly.