search

giorgiosironi / phpunit-selenium

Selenium RC integration for PHPUnit
http://www.phpunit.de/
Other
601 stars 270 forks source link

PHPUnit 8 support? #434

Closed luckydonald closed 4 years ago

luckydonald commented 5 years ago

Since earlier this year PHPUnit 8 is out, and 9 is already being worked on.

So after support for PHPUnit 7 #422 is almost released, According to commit aa5eb9503269bb8a11760baf73d1a337ce072f93 it is still missing some parts for compatibility.

luckydonald commented 5 years ago

Oh, just found #432 related to that specific issue left to do.

thewunder commented 5 years ago

I'll help address this after we get 7 out the door

KevP commented 4 years ago

Any update?

luckydonald commented 4 years ago

@KevP So far @thewunder has not left feedback in #432, which needs to be addressed before we can have a 8+ version.

Also using the fork (see https://github.com/giorgiosironi/phpunit-selenium/issues/422#issuecomment-508100154) might be a workaround if you don't need the screenshot class.

pajon commented 4 years ago

PHPUnit 8.x support https://github.com/giorgiosironi/phpunit-selenium/pull/441

thewunder commented 4 years ago

Thanks so much to @pajon for the great work!

pajon commented 4 years ago

Your welcome. Do we have a roadmap about what to next to do with this package ? For me is important to add support PHPUnit 9.x and do some changes to support also w3c protocol. But before we dive into w3c we need change architecture. I think will be good to migrate from dynamic handling commands (__call + annotations) like we use it now to more explicitly. Using less annotations (properties + methods) which can be messy if you need to understant how some code work. What do you think about it ?