search

giorgiosironi / phpunit-selenium

Selenium RC integration for PHPUnit
http://www.phpunit.de/
Other
601 stars 270 forks source link

Add phpcs + fix code #446

Open pajon opened 4 years ago

pajon commented 4 years ago

Hi guys,

i added phpcs to improve code quality. Rules were created from Doctrine + some rules were disabled.

Feel free to discus about it.

Thank you

P.S. This PR contains #445 fix.

pajon commented 4 years ago

@thewunder Sorry for tagging, but i need finish and merge this PR. I want continue with next changes.

pajon commented 4 years ago

I also added type hints to code. Sorry for doing multiple changes in one MR, but I understand you don't have much time to merge multiple MR. If you want i can split these changes into multiple MR.

pajon commented 4 years ago

@thewunder Can you review the PR?

Thank you