search

giorgiosironi / phpunit-selenium

Selenium RC integration for PHPUnit
http://www.phpunit.de/
Other
601 stars 270 forks source link

Fix phpunit method filter when multiple browsers are used #456

Closed ctrlaltca closed 2 years ago

ctrlaltca commented 2 years ago

This PR is a followup of https://github.com/giorgiosironi/phpunit-selenium/pull/449 The original PR fixed the method filter when only a single browser is being tested. This PR adds a similar fix when multiple browsers are being tested. Also, the test for $method->isPublic() has been removed, since TestUtil::isTestMethod() already checks if the method is public.

Fixes #453 Fixes #454

pajon commented 2 years ago

Hi @ctrlaltca, thank you for your work.