search

giorgosart / react-easy-edit

Inline editing library for React
https://giorgosart.gitbook.io/react-easy-edit/
MIT License
252 stars 46 forks source link

Allow Inline Edit on key press #103

Closed AndreasPatsimas closed 4 years ago

AndreasPatsimas commented 4 years ago

Is your feature request related to a problem? Please describe. A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]

Describe the solution you'd like A clear and concise description of what you want to happen.

Describe alternatives you've considered A clear and concise description of any alternative solutions or features you've considered.

Additional context Add any other context or screenshots about the feature request here.

AndreasPatsimas commented 4 years ago

It would be very useful to enable inline editing on key press. I think that this feature is not supported by your library. For example, on key tab press, it skips the field. If I am wrong please guide me. Thanks fro your time!

giorgosart commented 4 years ago

Hey @AndreasPatsimas thank you for logging a ticket with me. Help me understand this, let's assume that you have 5 EasyEdit components in a page and you start editing one, would you then press tab to move to the next one? So the next EasyEdit component's state would go from viewing to editing?

AndreasPatsimas commented 4 years ago

Exactly this!

giorgosart commented 4 years ago

@AndreasPatsimas I don't see how this could be implemented in the library itself as I will need to know any other occurrences of an EasyEdit component, and also there needs to be some sort of order so not sure I can support this. You could always add a wrapper component that would group all the EasyEdit components and have that do what you want to do above. Let me know if you have something else in mind.