search

giorgosart / react-easy-edit

Inline editing library for React
https://giorgosart.gitbook.io/react-easy-edit/
MIT License
249 stars 45 forks source link

Fix SonarCloud code smells for EasyEdit.jsx #196

Closed NohaFahmi closed 10 months ago

NohaFahmi commented 10 months ago

This PR includes fixes of the issue: https://github.com/giorgosart/react-easy-edit/issues/184

giorgosart commented 10 months ago

@NohaFahmi thanks for looking into this issue, i understand that this is a draft PR but can you please not reformat the file so that it would be easier for me to review? Also ensure that the tests are passing before you convert this into a formal PR. 🌟

sonarcloud[bot] commented 10 months ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

NohaFahmi commented 10 months ago

Hi @giorgosart, This PR is ready for review now and I have applied your comments as well. kindly check.