feature/Added no-color env support

gios / gzipper

CLI for compressing files.

https://www.npmjs.com/package/gzipper

GNU General Public License v3.0

68 stars 13 forks source link

feature/Added no-color env support #99

Closed VasylLymych closed 2 years ago

VasylLymych commented 2 years ago

Issue: https://github.com/gios/gzipper/issues/98

gios commented 2 years ago

@VasylLymych Thanks a lot for your PR, a couple of additions.

use predefined prettier and eslint configuration in order not to change the default formatting
if you want to add an additional ENV variable you have to add this functionality to CLI args as well
update CHANGELOG.md, README.md and increase the version in package,json
write tests for this additional argument

You can check this PR as an example PR

VasylLymych commented 2 years ago

@VasylLymych Thanks a lot for your PR, a couple of additions.

use predefined prettier and eslint configuration in order not to change the default formatting

if you want to add an additional ENV variable you have to add this functionality to CLI args as well

update CHANGELOG.md, README.md and increase the version in package,json

write tests for this additional argument

You can check this PR as an example PR

Sorry i missed your comment) Done

emzet commented 2 years ago

@VasylLymych good job, thanks. @gios when you expect to merge and release a new version?

gios commented 2 years ago

@VasylLymych good job, thanks. @gios when you expect to merge and release a new version?

Hi @emzet, sorry for the very long response, created PR for this https://github.com/gios/gzipper/pull/100, will be merged and published soon a new version.