Add NB for BERT models - Githubissues

hkirvesl commented 2 years ago

Reference issues/PRs

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Description

Screenshots (if appropriate)

Any other comments? I checked all the tests, the only one that failed was gdeep/visualisation/tests/test_visualiser.py which I believe is caused by local issues in my own environment Checklist

[x] I have read the guidelines for contributing.
[x] My code follows the code style of this project. I used flake8 to check my Python changes.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have added tests to cover my changes.
[/] All new and existing tests passed. I used pytest to check this on Python tests.

CLAassistant commented 2 years ago

All committers have signed the CLA.

matteocao commented 2 years ago

Dear @hkirvesl ,

Is it correct to merge the master branch of your fork? I saw the changes in the other branch hkdev. If that's the case, can you please update this PR? thanks!

hkirvesl commented 2 years ago

ugh, created the PR from wrong branch. Closing and reopening with the correction

giotto-ai / giotto-deep

Add NB for BERT models #111