search

giotto-ai / giotto-ph

High performance implementation of Vietoris-Rips persistence.
https://giotto-ai.github.io/giotto-ph/
Other
43 stars 12 forks source link

maxdim=0 #39

Closed mglisse closed 2 years ago

mglisse commented 2 years ago

Hello, I tried to run gph.ripser_parallel(np.array([[1.,2],[3,4],[5,0]]), maxdim=0) but it segfaults (while it works with maxdim=1).

MonkeyBreaker commented 2 years ago

Hello,

Thank you for reporting the issue. After debugging what was going on, I found out a fix. Currently a PR (#40) is in progress for patching this issue.

Sorry that you encountered a bug and thank you for reporting it with an example.

Best, Julián

MonkeyBreaker commented 2 years ago

The fix is now merged but currently not available in PyPI. We will soon release version 0.2.0, but on the meantime if you want to work with giotto-ph with maxdim=0 fix, you can follow the developer installation.