Add homology_dimensions to diagrams transformers

giotto-ai / giotto-tda

A high-performance topological machine learning toolbox in Python

https://giotto-ai.github.io/gtda-docs

Other

847 stars 173 forks source link

Add homology_dimensions to diagrams transformers #107

Open nphilou opened 4 years ago

nphilou commented 4 years ago

Description

In the current implementation of diagrams.Scaler, Amplitude and PersistenceEntropy, homology dimensions that don't appear in fit will not be considered in transform.

It might lead to some unexpected results.

Possible improvements

Documentation
Add homology_dimensions parameter (as done for Filtering) to transformers that might ignore some dimensions in transform

PS: Maybe I'm the only one who thinks that it's not clear enough

ulupo commented 2 years ago

This is still relevant, and should be bumped.