giotto-ai / giotto-tda

A high-performance topological machine learning toolbox in Python
https://giotto-ai.github.io/gtda-docs
Other
858 stars 175 forks source link

Tests for plotting functions and methods, other increases in test coverage #384

Closed ulupo closed 4 years ago

ulupo commented 4 years ago

Reference issues/PRs Addresses several remaining gaps in coverage (but still not the ones indicated in #182).

Types of changes

Description

Checklist

ulupo commented 4 years ago

@wreise @gtauzin one downside of having plot methods which not only create figures but also show them is that locally running tests causes one tab per plot to be automatically opened by my browser. Have you encountered/resolved this?

ulupo commented 4 years ago

The failures in the manylinux builds seem to be related to a problem with the boost website. I wouldn't worry too much about it yet, hopefully it will be up and running soon.

ulupo commented 4 years ago

@gtauzin this is ready to merge and the new coverage percentage is between 93% and 94%. Due to issues at the boost website's end (Forbidden errors when following the tar.gz download link), we are delaying merging until the latter works as expected again.