Closed reds-heig closed 4 years ago
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.
:white_check_mark: ulupo
:x: MonkeyBreaker
You have signed the CLA already but the status is still pending? Let us recheck it.
@ulupo can you please look why it fails on Mac now ? Apparently the flake8 has an issue ? Not sure I understand why
@MonkeyBreaker this seems to be due to a new release of flake8
(3.8.1) made 4 hours ago! I have make a change to help with the situation.
@ulupo great !
I don't know why sometimes the pipeline doesn't show all the step ... But, every step has run smoothly, I think we can merge this PR.
@MonkeyBreaker thanks! Out of curiosity, is there a plan to fix the warnings which seem to have caused this issue, at some point?
@ulupo I'm not sure I understand about which warnings are you talking about
@MonkeyBreaker I'm referring to what seems to have caused problems before, namely https://dev.azure.com/maintainers/Giotto/_build/results?buildId=2082&view=logs&j=e1e30141-6252-56cf-eccb-600499366ae7&t=d9621201-b199-5a6f-a2d0-2aa31b7b1f05&l=663. It seems to me the fix is effectively to silence these warnings/errors?
Yes, the issue was that the updated compiler for Mac, requires to pass the standard version (In our case c++14). And because we didn't pass any, it raised warnings about using features for c++11 and of course created errors because the standard was not set to at least c++11.
the standard was not set to at least c++11
Do you mean "at least C++14"?
No, c++11
, that's what the warnings has been printing. I aligned with pyflagser
because pyflagser
requires c++14
.
Reference issues/PRs
Types of changes
Description
This PR will fix current issue encountered due to pipeline update the XCode compiler (actions/virtual-environments#777)
Checklist
flake8
to check my Python changes.pytest
to check this on Python tests.