search

giotto-ai / giotto-tda

A high-performance topological machine learning toolbox in Python
https://giotto-ai.github.io/gtda-docs
Other
847 stars 173 forks source link

Input check for geodesic_distance in graphs submodule #43

Open Amg88 opened 4 years ago

Amg88 commented 4 years ago

Description

A check_graph function is needed in order to check the input adjacency matrices for the geodesic_distance.py; moreover tests to check the behaviour of this function are also needed.

Steps/Code to Reproduce

Expected Results

Actual Results

Versions

ulupo commented 4 years ago

@Amg88, so as to keep this on record, could you please provide here the specifications for this function?

Amg88 commented 4 years ago

@Amg88, so as to keep this on record, could you please provide here the specifications for this function?

@ulupo, I add the specifications into the validation.py file, basically this function should check the maximum X shape dimension and the facts that every adjancency matrix should be a square symmetric matrix, with every diagonal elements equal to 0.