search

giotto-ai / giotto-tda

A high-performance topological machine learning toolbox in Python
https://giotto-ai.github.io/gtda-docs
Other
858 stars 175 forks source link

New list created by check_point_clouds even when copy=False #431

Open ulupo opened 4 years ago

ulupo commented 4 years ago

It seems that the input is systematically copied and returned. In sklearn, there is a copy boolean argument to the check_array function. This is especially useful if one of the function in transform is already returning a copy of the sample or if it does not modify the input at all.

_Originally posted by @gtauzin in https://github.com/_render_node/MDIzOlB1bGxSZXF1ZXN0UmV2aWV3VGhyZWFkMjc2ODE3ODEwOnYy/pull_request_review_threads/discussion_

The reason for this situation is explained in my responses https://github.com/giotto-ai/giotto-tda/pull/424#issuecomment-648844401 and https://github.com/giotto-ai/giotto-tda/pull/424#issuecomment-649536688. However, a better solution may be found.